D14814: Port away from kdelibs4support

Elvis Angelaccio noreply at phabricator.kde.org
Mon Aug 13 23:21:46 BST 2018


elvisangelaccio created this revision.
elvisangelaccio added reviewers: Dolphin, broulik, ngraham.
Restricted Application added a project: Dolphin.
Restricted Application added a subscriber: kfm-devel.
elvisangelaccio requested review of this revision.

REVISION SUMMARY
  It was only used as fallback when baloo was not found, but
  `KFileMetaDataWidget` is useless without nepomuk.
  
  The result of this patch is that the information panel and the tooltips
  won't be available from platforms without baloo (instead of being
  available but broken). The baloo dependency remains optional.
  
  Closes T8720 <https://phabricator.kde.org/T8720>

TEST PLAN
  Build dolphin with `cmake -DCMAKE_DISABLE_FIND_PACKAGE_KF5Baloo=ON ..` and
  make sure it doesn't show tooltips or the information panel.

REPOSITORY
  R318 Dolphin

BRANCH
  no-kdelibs4support

REVISION DETAIL
  https://phabricator.kde.org/D14814

AFFECTED FILES
  CMakeLists.txt
  src/CMakeLists.txt
  src/dolphinmainwindow.cpp
  src/panels/information/filemetadataconfigurationdialog.cpp
  src/panels/information/filemetadataconfigurationdialog.h
  src/panels/information/informationpanelcontent.cpp
  src/views/dolphinview.cpp
  src/views/tooltips/dolphinfilemetadatawidget.cpp
  src/views/tooltips/dolphinfilemetadatawidget.h

To: elvisangelaccio, #dolphin, broulik, ngraham
Cc: kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180813/ed3aa278/attachment.htm>


More information about the kfm-devel mailing list