D14442: Unify window and tab title

[David Hallas]

hallas added a comment.


  In D14442#305452 <https://phabricator.kde.org/D14442#305452>, @ngraham wrote:
  
  > Thanks for the ping, sometimes things get lost when everyone's busy!
  >
  > Conceptually, I am in strong agreement with this. It makes sense that the tab title is the same as the window title.
  >
  > However, this introduces a slight regression in tab names for certain use cases: KIOSlaves now have a trailing ` - /` at the end of them. E.g. open a new tab and go to `tags://` before and after applying your patch, then compare the tab titles. This is a pre-existing issue for the window title, but by using that window title for the tab title, we inherit the issue. The old tab title handling code handled that; do you think you could update the diff to handle it for the window title too so that the tab titles re-inherit the behavior?
  
  
  No worries :)
  
  Thanks for the feedback, I will look into this issue and see if I can fix it.
  
  So just to clarify the behavior; there should never be a ` - /` in the window title or the tab title? This seems to be added specifically by line 416-421 and then appending the fileName or '/' if it is empty, so should this code simply be removed? What information is relevant for the user in this case? Maybe just showing the URL as the user has typed it is the most sane, so in the example you provide, the window title and tab title would simply be `tags://` ? Personally I prefer this simple behavior of showing the short hand URL or the full path, depending on your settings (GeneralSettings::showFullPathInTitlebar).

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14442

To: hallas, #dolphin, ngraham, elvisangelaccio
Cc: markg, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180808/9d80f28d/attachment.htm>