D14442: Unify window and tab title

[Nathaniel Graham]

ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.


  Thanks for the ping, sometimes things get lost when everyone's busy!
  
  Conceptually, I am in strong agreement with this. It makes sense that the tab title is the same as the window title.
  
  However, this introduces a slight regression in tab names for certain use cases: KIOSlaves now have a trailing ` - /` at the end of them. E.g. open a new tab and go to `tags://` before and after applying your patch, then compare the tab titles. This is a pre-existing issue for the window title, but by using that window title for the tab title, we inherit the issue. The old tab title handling code handled that; do you think you could update the diff to handle it for the window title too so that the tab titles re-inherit the behavior?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D14442

To: hallas, #dolphin, ngraham, elvisangelaccio
Cc: markg, kfm-devel, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180808/6f383744/attachment.htm>