D12321: Hide file preview when icon is too small

[Henrik Fehlauer]

rkflx added a comment.


  In D12321#252238 <https://phabricator.kde.org/D12321#252238>, @markg wrote:
  
  > That looks really fancy! :)
  >  Yet i have to give it a -1..
  >
  > You are overwriting a setting that the user had explicitly set (show preview). That will result in a "huh, why is the preview off all of a sudden?" responses which will lead to bug reports.
  
  
  That's simply a bug with the patch: Enable previews, set small icon set, click Cancel, reopen dialog, set large icon size. Previews should still be enabled, but they are not. I guess this needs to track separately what the user set vs. what the button says (as for small sizes the thumbnails are turned off by the slider, not by the user) when writing to the config.
  
  > This logic breaks in really high resolution displays (take smartphones for example) where a 1x1 cm block can (and should!) easily show you an image. But lets lets consider that a out-of-scope issue as dolphin isn't on the smartphone (that i'm aware of), just something that might need to be considered in the future.
  
  The patch is basing the cut-off point on the logical size, not on the physical size, and as such should work just fine in HiDPI mode. Also, in general the font size is a good approximation on what sizes user prefer. There is no need to make every single aspect of our UI's behaviour configurable, because we should pick good defaults.
  
  > That being said, having an "auto preview" (aka, the view knows best, your implementation) would be awesome! But not as overridden user setting.
  >  Perhaps the preview button needs to become a tri-state button:
  > 
  > - Off
  > - On (always a preview, the user knows best)
  > - Auto (the view decides when you see a preview)
  
  I think this was discussed before, and rejected? @ngraham Can you remember?

REPOSITORY
  R241 KIO

REVISION DETAIL
  https://phabricator.kde.org/D12321

To: anemeth, #vdg, #frameworks, ngraham, rkflx, #dolphin, markg
Cc: markg, xyquadrat, sharvey, rkflx, ngraham, #frameworks, michaelh, bruns
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180423/7dbcf485/attachment.htm>