D12162: Support for touch scrolling in Dolphin

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> kitemlistcontroller.cpp:1392-1407
> +            bool emitItemActivated = true;
> +            if (m_view->isAboveExpansionToggle(index, pos)) {
> +                const bool expanded = m_model->isExpanded(index);
> +                m_model->setExpanded(index, !expanded);
> +
> +                emit itemExpansionToggleClicked(index);
> +                emitItemActivated = false;

emitItemActivated increases complexity, so just remove it

  if (m_view->isAboveExpansionToggle(index, pos)) {
      const bool expanded = m_model->isExpanded(index);
      m_model->setExpanded(index, !expanded);
      emit itemExpansionToggleClicked(index);
  } else if (shiftOrControlPressed || m_singleClickActivationEnforced
  || !(m_view->style()->styleHint(QStyle::SH_ItemView_ActivateItemOnSingleClick))) {
      // The mouse click should only update the selection, not trigger the item
  } else {
      emit itemActivated(index);
  }

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D12162

To: abalaji, #dolphin, ngraham
Cc: anthonyfieroni, ngraham, #dolphin, spoorun, navarromorales, isidorov, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20180414/08d09475/attachment.htm>