D7690: Add "Open in New Window to Dolphin's places context menu

[Emmanuel Pescosta]

emmanuelp requested changes to this revision.
emmanuelp added inline comments.
This revision now requires changes to proceed.

INLINE COMMENTS

> broulik wrote in placespanel.cpp:238
> Why do you need `upUrl` here?

Please use `PlacesItemModel::convertedUrl(m_model->data(index).value("url").toUrl())` instead

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7690

To: ngraham, #dolphin, #kde_applications, dfaure, aacid, elvisangelaccio, emmanuelp
Cc: emmanuelp, broulik, sefaeyeoglu, #dolphin, navarromorales, firef, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170906/e0ae69a4/attachment.htm>