D7690: Add "Open in New Window to Dolphin's places context menu

Kai Uwe Broulik noreply at phabricator.kde.org
Wed Sep 6 09:50:38 BST 2017


broulik added inline comments.

INLINE COMMENTS

> placespanel.cpp:238
> +            } else if (action == openInNewWindowAction) {
> +                Dolphin::openNewWindow({KIO::upUrl(m_model->data(index).value("url").toUrl())}, this);
>              } else if (action == openInNewTabAction) {

Why do you need `upUrl` here?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7690

To: ngraham, #dolphin, #kde_applications, dfaure, aacid, elvisangelaccio
Cc: broulik, sefaeyeoglu, #dolphin, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170906/635d5ffc/attachment.htm>


More information about the kfm-devel mailing list