D8454: Make Saved Search feature discoverable

[Nathaniel Graham]

ngraham added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in dolphincontextmenu.cpp:312
> You can use again "folder-saved-search-symbolic" to be consistant with places icon. I don't think it's KIO or KProtocolInfo bug because from searching url it can't determine what icon to return, search or save.

I don't think I can make it always return  "folder-saved-search-symbolic", because this function is called from many other contexts, and often needs to return other icons. If I add a specific check for "baloosearch:" URLs, I'm just needlessly re-implementing part of `KIO::iconNameForUrl()`.

IMHO the real fix is indeed to fix `KIO::iconNameForUrl()` since the non-symbolic icon it returns for all "search:" and "baloosearch:" URLs is out of place in other contexts too. For example, open another tab; in one, go to "timeline:/today", and in the other, go to "search:/documents". Observe how the first tab icon is an appropriate symbolic magnifying glass icon, while the second one is an inappropriate blue document icon.

I plan on fixing `KIO::iconNameForUrl()` soon, don't worry. :)

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8454

To: ngraham, #dolphin, #kde_applications, broulik, dfaure, markg, emateli, elvisangelaccio
Cc: anthonyfieroni, markg, emateli, elvisangelaccio, cfeck, #dolphin, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171029/4756b0e7/attachment.htm>