D8454: Make Saved Search feature discoverable

Anthony Fieroni noreply at phabricator.kde.org
Sun Oct 29 06:20:53 GMT 2017


anthonyfieroni added inline comments.

INLINE COMMENTS

> dolphincontextmenu.cpp:312
> +                // https://bugs.kde.org/show_bug.cgi?id=386182
> +                PlacesItem* item = model.createPlacesItem(container->placesText(), selectedUrl, KIO::iconNameForUrl(selectedUrl));
>                  model.appendItemToGroup(item);

You can use again "folder-saved-search-symbolic" to be consistant with places icon. I don't think it's KIO or KProtocolInfo bug because from searching url it can't determine what icon to return, search or save.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D8454

To: ngraham, #dolphin, #kde_applications, broulik, dfaure, markg, emateli, elvisangelaccio
Cc: anthonyfieroni, markg, emateli, elvisangelaccio, cfeck, #dolphin, spoorun, navarromorales, firef, ngraham, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171029/c06b1e3d/attachment.htm>


More information about the kfm-devel mailing list