D6281: Prevent folders from drag and dropping onto themselves in dolphin main view

[Henrik Fehlauer]

rkflx accepted this revision.
rkflx added a comment.


  Ok, you duplicated it everywhere where necessary. Not elegant, but perhaps the best we can do without introducing more classes. Compiles now for me, which is great.
  
  > I had in mind methonds which just return `bool PlacesItemModel::indexIsDir(int index) const` this I know to be unnecessary
  
  Isn't what you mean `const bool f()` and not `bool g() const`, though? The first is about the return type, the second is about what the function is allowed to do in its implementation (i.e. cannot modify members and cannot call non-const member functions).
  
  ---
  
  Marking this as accepted from my side, as you fixed both the unintentional auto-open and the compile failure. I still think adding the "good" `const` would be better.
  
  Note I did not review the complete Diff, so you should still get approval from the other reviewers.
  
  @elvisangelaccio @ngraham You still have open change requests. Are those solved now?

REVISION DETAIL
  https://phabricator.kde.org/D6281

To: emateli, #dolphin, elvisangelaccio, ngraham, rkflx
Cc: rkflx, ngraham, elvisangelaccio, dfaure, anthonyfieroni, #konqueror, spoorun, navarromorales, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171027/fff17a28/attachment.htm>