D7440: Turn on Dolphin icon previews by default

[Mark Gaiser]

markg requested changes to this revision.
markg added a comment.
This revision now requires changes to proceed.


  At the very least - regardless of my previous comment - you'd also have to raise the minimum required frameworks version in Dolphin' CMakeLists.txt.
  It's the line: set(KF5_MIN_VERSION "5.37.0") which has to be changed to set(KF5_MIN_VERSION "5.40.0").
  
  And that very action will cause the build to break as 5.40.0 isn't released yet :)
  A push of this change should only happen after Frameworks 5.40 is released, to not break compiling Dolphin.
  
  @others, isn't there some trick in CMake to say "i require a minimum version of 5.40 or current GIT master?"

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7440

To: ngraham, #dolphin, #kde_applications, #vdg, markg
Cc: cfeck, andreaska, emmanuelp, andreask, markg, broulik, anthonyfieroni, davidedmundson, ltoscano, dfaure, elvisangelaccio, #konqueror, spoorun, navarromorales, firef, ngraham, andrebarros
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171021/982135d4/attachment.htm>