D8991: Use kSqueezedTextLabel for the label text on the statusbar

Elvis Angelaccio noreply at phabricator.kde.org
Sat Nov 25 15:30:29 GMT 2017


elvisangelaccio requested changes to this revision.
elvisangelaccio added a comment.
This revision now requires changes to proceed.


  In https://phabricator.kde.org/D8991#171872, @ahmadsamir wrote:
  
  > - To reproduced the issue of the widgets on the statusbar, we just need to remove the stretch factor from the addWidget() call, or set it to zero (default).
  
  
  Ah I see, the problem happens only after porting to KSqueezedTextLabel (which probably has a different size hint).

INLINE COMMENTS

> dolphinstatusbar.cpp:330-334
> -    if (text != elidedText) {
> -        m_label->setToolTip(Qt::convertFromPlainText(text));
> -    } else {
> -        m_label->setToolTip(QString());
> -    }

Please don't remove the tooltip, we can still show it if `m_label->isSqueezed()` is true.

REVISION DETAIL
  https://phabricator.kde.org/D8991

To: ahmadsamir, elvisangelaccio
Cc: elvisangelaccio, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20171125/ff1107c8/attachment.htm>


More information about the kfm-devel mailing list