D5864: Correct specified transitions between searchbox, url navigator, tabs and split views

[Anthony Fieroni]

anthonyfieroni added inline comments.

INLINE COMMENTS

> elvisangelaccio wrote in dolphinmainwindow.cpp:1474-1476
> I still think that https://phabricator.kde.org/D5919 would be a better fix for https://bugs.kde.org/show_bug.cgi?id=379135
> 
> It is just wrong that DolphinTabWidget's `widget(currentIndex())` returns nullptr if `currentIndex() == 1` and `count() == 2`.
> 
> But the rest of this patch looks good as fix for https://bugs.kde.org/show_bug.cgi?id=380032

I saw the code in QTabWdiget, i think the problem is the quque looks like:
currentChanged
widgetRemoved
focusIn (searchbox)
real index changed
deleteLater (tabPage)
I'll change tabPage->deleteLater to delete tabPage, what you think?

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D5864

To: anthonyfieroni, elvisangelaccio, emmanuelp, sandsmark
Cc: #konqueror, #dolphin, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170521/80cbdedc/attachment.htm>