D5864: Correct specified transitions between searchbox, url navigator, tabs and split views

Elvis Angelaccio noreply at phabricator.kde.org
Sun May 21 15:20:41 BST 2017


elvisangelaccio added inline comments.

INLINE COMMENTS

> anthonyfieroni wrote in dolphintabpage.cpp:298
> If split is disabled m_active bacame true, but we want view to goes from false to true, this will not happen we will have
> setActive(m_active) // true
> next time setActive(m_active) // true again

Ok, please add some comments because this could be confusing.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D5864

To: anthonyfieroni, elvisangelaccio, emmanuelp, sandsmark
Cc: #konqueror, #dolphin, firef, andrebarros, emmanuelp
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170521/7552ab79/attachment.htm>


More information about the kfm-devel mailing list