D6182: Change in "Open in new tab" feature in Dolphin

[Elvis Angelaccio]

elvisangelaccio accepted this revision.
elvisangelaccio added a comment.
This revision is now accepted and ready to land.


  After thinking more about it, I agree this behavior is acceptable. After all the "Open in new Tab" actions are meant for the context menu and are not in the toolbar, by default.

INLINE COMMENTS

> dolphinmainwindow.cpp:310
> +    const KFileItemList& list = m_activeViewContainer->view()->selectedItems();
> +    bool flag = false;
> +

Please choose a better name for this variable, "flag" is too generic and doesn't tell what the variable is used for.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D6182

To: emateli, #dolphin, elvisangelaccio
Cc: elvisangelaccio
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170611/701b678b/attachment.htm>