D6781: Allow konqueror to embed / open in a new window downloaded files using webengine part

David Faure noreply at phabricator.kde.org
Sat Jul 22 11:45:30 BST 2017


dfaure accepted this revision.
dfaure added a comment.
This revision is now accepted and ready to land.


  Let's get this in even if there are a few issues left, it's certainly much better than the current behaviour ;)
  
  I talked to Allan about getting the page pointer (if any) when WebEngine signals a download, he says there were other requests for that, so maybe one day we'll get that. Meanwhile this is necessary indeed.

INLINE COMMENTS

> webenginepartdownloadmanager.h:42
> +public Q_SLOTS:
> +  void addPage(WebEnginePage *page);
> +  void removePage(QObject *page);

>From this line onwards it's all intended with 2 spaces instead of 4

REPOSITORY
  R226 Konqueror

REVISION DETAIL
  https://phabricator.kde.org/D6781

To: stefanocrocco, dfaure
Cc: #konqueror, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170722/bf23e04f/attachment.htm>


More information about the kfm-devel mailing list