D6781: Allow konqueror to embed / open in a new window downloaded files using webengine part

[Stefano Crocco]

stefanocrocco updated this revision to Diff 17006.
stefanocrocco added a comment.


  Made the requested changes. Regarding `KBrowserArguments::setNewTab`, I removed that line completely, as that workaround doesn't work anymore. Clicking on a link with attributes `target="_blank"` download` doesn't display the file anywhere, even if it seems a view is created for it (at least, I see a qDebug output from `KonqView::openUrl` at line 150 with the correct URL. I'll have to investigate this issue.

REPOSITORY
  R226 Konqueror

CHANGES SINCE LAST UPDATE
  https://phabricator.kde.org/D6781?vs=16908&id=17006

REVISION DETAIL
  https://phabricator.kde.org/D6781

AFFECTED FILES
  webenginepart/src/CMakeLists.txt
  webenginepart/src/webenginepage.cpp
  webenginepart/src/webenginepage.h
  webenginepart/src/webenginepartdownloadmanager.cpp
  webenginepart/src/webenginepartdownloadmanager.h

To: stefanocrocco, dfaure
Cc: #konqueror, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170722/c7b54952/attachment.htm>