Review Request 129044: Adding a dedicated Stash action button in Dolphin for the upcoming stash:/ ioslave

[arnav dhamija]

> On Nov. 20, 2016, 11:16 a.m., Emmanuel Pescosta wrote:
> > Currently the state of the stash view is shared between the action (check/unchecked) and the tab page, this may lead to some problems in future.
> > I think it would be better if only the tab page keeps the state, the "visual state" of action is adjusted by updateSplitAction depending on the state of the tab page (same as the normal split action) and also toggleSplitStash should just use the state of the tab page to decide if split view has to be enabled or disabled.
> 
> arnav dhamija wrote:
>     Yes, the current patch is very clumsy. It is just a placeholder for my current progress till I finally get enough time to work on it (after Dec 14 due to uni exams T_T!). Thanks for the review though!
> 
> Emmanuel Pescosta wrote:
>     No problem, we have time until the freeze of 17.04 to finalize it ;)
>     
>     > due to uni exams T_T!
>     
>     Good luck!

Finally working on this now. As I come to think of it, it is better for the stash button to **not** be checkable. If the user chooses to close it, they can do so through the Split close button. I think it is better if the Stash button just opens the stash:/ slave in a split view. Keeping it as a checkable button is causing too many async with the button being pressed to be worth it.


- arnav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129044/#review100960
-----------------------------------------------------------


On Nov. 3, 2016, 4:09 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129044/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 4:09 a.m.)
> 
> 
> Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The [stash:/ ioslave](https://github.com/KDE/kio-stash) provides an easy and convenient way for saving the URLs of complicated selections of files. To make this feature more useful, there have been suggestions to have a dedicated shortcut and GUI button for accessing the ioslave in a Split window. This patch adds a QAction in the DolphinMainWindow class for this purpose. The shortcut is subject to change and is currently set as Ctrl+**S**tash. By default, the action is visible in the View menu and the Toolbar of Dolphin.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.h 7003e94 
>   src/dolphinmainwindow.cpp 4d97fc1 
>   src/dolphintabpage.h 9d18088 
>   src/dolphintabpage.cpp c674e1e 
>   src/dolphinui.rc f197af4 
> 
> Diff: https://git.reviewboard.kde.org/r/129044/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of the button in the toolbar
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/27/2cb91ab8-5693-4953-b067-1ded856dd622__Screenshot_20160927_144649.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170129/86e17eef/attachment.htm>