Review Request 129044: Adding a dedicated Stash action button in Dolphin for the upcoming stash:/ ioslave

[arnav dhamija]

> On Nov. 20, 2016, 11:16 a.m., Emmanuel Pescosta wrote:
> > src/dolphinmainwindow.cpp, line 538
> > <https://git.reviewboard.kde.org/r/129044/diff/2/?file=483915#file483915line538>
> >
> >     You need to check which view shows the stash folder, active it and then disable the split view (the active view will be closed if split view gets disabled).

That is actually the intention :) I close the view and then re-open it with the stash folder in a split view so that I don't need to worry about not triggering the slot again. As it can been seen from the code of setSplitViewEnabled in the dolphintabpage.cpp file, it doesn't do any logic when the Split window is already open.


> On Nov. 20, 2016, 11:16 a.m., Emmanuel Pescosta wrote:
> > src/dolphinmainwindow.cpp, line 1483
> > <https://git.reviewboard.kde.org/r/129044/diff/2/?file=483915#file483915line1483>
> >
> >     In this case you need to check if any of the views shows the stash folder and enable/disable the stash action accordingly.

Yeah. One of the issues is that the Stash action remains depressed even when one navigates to a different page.


- arnav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129044/#review100960
-----------------------------------------------------------


On Nov. 3, 2016, 4:09 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129044/
> -----------------------------------------------------------
> 
> (Updated Nov. 3, 2016, 4:09 a.m.)
> 
> 
> Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The [stash:/ ioslave](https://github.com/KDE/kio-stash) provides an easy and convenient way for saving the URLs of complicated selections of files. To make this feature more useful, there have been suggestions to have a dedicated shortcut and GUI button for accessing the ioslave in a Split window. This patch adds a QAction in the DolphinMainWindow class for this purpose. The shortcut is subject to change and is currently set as Ctrl+**S**tash. By default, the action is visible in the View menu and the Toolbar of Dolphin.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.h 7003e94 
>   src/dolphinmainwindow.cpp 4d97fc1 
>   src/dolphintabpage.h 9d18088 
>   src/dolphintabpage.cpp c674e1e 
>   src/dolphinui.rc f197af4 
> 
> Diff: https://git.reviewboard.kde.org/r/129044/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of the button in the toolbar
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/27/2cb91ab8-5693-4953-b067-1ded856dd622__Screenshot_20160927_144649.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170129/16724b06/attachment.htm>