Looking for co-mentors for a GSoC Dolphin/KIO project

[David Faure]

On dimanche 15 janvier 2017 23:15:06 CET Elvis Angelaccio wrote:
> On Sun, Jan 15, 2017 at 10:37 AM, David Faure <faure at kde.org> wrote:
> > On samedi 14 janvier 2017 23:58:45 CET Elvis Angelaccio wrote:
> >> Hi,
> >> I played a bit with kauth in the file ioslave [1] and everything seems
> >> to work nicely :)
> >> [2] is a patch for kio that allows to delete file:// URLs upon polkit
> >> authentication.
> >> 
> >> The helper just calls unlink(). In the patch I call the helper (from
> >> the ioslave) only if unlink() failes with EACCES or EPERM errors.
> >> This could be seen as code duplication (because we have unlink in two
> >> places), one of the things Aleix was afraid of. On the other hand, why
> >> call an helper process if you don't need it?
> > 
> > Well, let me just say, this is seriously cool. Nice job, Elvis!
> 
> Thanks :)
> 
> Btw, is there a reason why the implementation of the file ioslave is
> splitted in unix and windows backends that use native stuff?
> Hystoric reasons? Or QFile is missing something?

Historical reasons for sure, but even now I'm not sure QFile
1) has everything we need
2) is as fast as this code.

For sure ACLs are something that is not handled by QFile so that would have to 
remain unix-specific code.

There are optimizations like the use of sendfile in copy() that are not in Qt 
AFAIK. And utime() still isn't in Qt (there was a patch under review for 
QFile[Info?]::setFileTimes but it doesn't look like it went in). Etc.

-- 
David Faure, faure at kde.org, http://www.davidfaure.fr
Working on KDE Frameworks 5