Review Request 118961: Treat video thumbnails the same as image thumbnails

[Diego S.]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118961/
-----------------------------------------------------------

(Updated Feb. 4, 2017, 9:48 a.m.)


Status
------

This change has been discarded.


Review request for Dolphin.


Repository: kde-baseapps


Description
-------

A minor (but very noticeable) inconsistency that has been bugging me in Dolphin is the fact that video thumbnails don't get the nice shadow frame added that image thumbnails have.
Video snapshots are essentially images, and often times these two file types will be in the same folder. So to me it doesn't make sense to treat them differently.


Diffs
-----

  dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 0865d40 

Diff: https://git.reviewboard.kde.org/r/118961/diff/


Testing
-------

Works fine (see before/after screenshots).


File Attachments
----------------

Before
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/26/11ed57e4-04af-4ff0-9963-7a183dfcb035__before.png
After
  https://git.reviewboard.kde.org/media/uploaded/files/2014/06/26/ae8c87c1-fb61-48ee-ba3c-11070752edb3__after.png


Thanks,

Diego S.

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170204/9c1308ba/attachment.htm>