Review Request 118961: Treat video thumbnails the same as image thumbnails

[Diego S.]

> On Jan. 21, 2017, 1:02 a.m., Albert Astals Cid wrote:
> > The patch is only whitespace, is this because the patch was commited?
> 
> Diego S. wrote:
>     It don't think it was submitted. This was before Frameworks 5 etc so maybe enough things changed so the diff no longer works on current sources?
> 
> Albert Astals Cid wrote:
>     It's not that the diff doesn't work, it's just that there's no diff.
>     
>     https://git.reviewboard.kde.org/r/118961/diff/raw/ gives an empty file.

I don't know what happened to it. The diff was really simple though. It's basically just a simple edit to https://github.com/KDE/dolphin/blob/master/src/kitemviews/kfileitemmodelrolesupdater.cpp#L509 - at least for the Dolphin side of things. https://github.com/KDE/kio-extras/blob/master/thumbnail/thumbnail.cpp#L263 is responsible for adding the 1px black and white border around non-image previews. I believe the Dolphin behavior is also duplicated somewhere in Frameworks and use by Plasma for the desktop (I'm not sure it's been a long time).

I do hope someone more knowladgeble than me can actually implement this change and bring the previews into the current year. All of them, except for image previews look really outdated currently, especially video file previews. Even more so now the the rest of the UI has been modernized with Breeze etc.


- Diego


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/118961/#review102144
-----------------------------------------------------------


On June 26, 2014, 6:59 p.m., Diego S. wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/118961/
> -----------------------------------------------------------
> 
> (Updated June 26, 2014, 6:59 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: kde-baseapps
> 
> 
> Description
> -------
> 
> A minor (but very noticeable) inconsistency that has been bugging me in Dolphin is the fact that video thumbnails don't get the nice shadow frame added that image thumbnails have.
> Video snapshots are essentially images, and often times these two file types will be in the same folder. So to me it doesn't make sense to treat them differently.
> 
> 
> Diffs
> -----
> 
>   dolphin/src/kitemviews/kfileitemmodelrolesupdater.cpp 0865d40 
> 
> Diff: https://git.reviewboard.kde.org/r/118961/diff/
> 
> 
> Testing
> -------
> 
> Works fine (see before/after screenshots).
> 
> 
> File Attachments
> ----------------
> 
> Before
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/26/11ed57e4-04af-4ff0-9963-7a183dfcb035__before.png
> After
>   https://git.reviewboard.kde.org/media/uploaded/files/2014/06/26/ae8c87c1-fb61-48ee-ba3c-11070752edb3__after.png
> 
> 
> Thanks,
> 
> Diego S.
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170204/09ae6834/attachment.htm>