D7477: Limit folder panel to home directory if inside home

Robert Hoffmann noreply at phabricator.kde.org
Wed Aug 30 11:34:23 BST 2017


hoffmannrobert marked 4 inline comments as done.
hoffmannrobert added inline comments.

INLINE COMMENTS

> emmanuelp wrote in folderspanel.cpp:195
> Why is this change required?

This change is from our original patch against KDE4 I ported. Neither do I know why this was changed, nor does it seem to have any negative effects to leave it out. So I removed the change.

> emmanuelp wrote in folderspanel.cpp:357
> This shouldn't be required, see `FoldersPanel::slotLoadingCompleted`.

Here, it is required: if a subdirectory of home has been selected previously before selecting home itself, the previous selection is not cleared. There is nothing to be newly selected in the folders panel in this case.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7477

To: hoffmannrobert, #dolphin, elvisangelaccio, emmanuelp
Cc: emmanuelp, elvisangelaccio, #konqueror, #dolphin
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170830/22f0c26f/attachment.htm>


More information about the kfm-devel mailing list