D7390: Support middle clicking of Back/Forward/Up/Home toolbar buttons

[Emmanuel Pescosta]

emmanuelp added a comment.


  Nice addition :)

INLINE COMMENTS

> middleclickactioneventfilter.cpp:41
> +        if (me->button() == Qt::MiddleButton) {
> +            QToolBar *toolBar = qobject_cast<QToolBar *>(watched);
> +

This is dangerous if `watched` isn't a `QToolbar` or a subclass of it.

REPOSITORY
  R318 Dolphin

REVISION DETAIL
  https://phabricator.kde.org/D7390

To: broulik, #dolphin, elvisangelaccio, dfaure
Cc: emmanuelp, #konqueror
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20170825/43df8b64/attachment.htm>