Review Request 128666: Change KFileItemModel's createMimeData handling so it supports the upcoming stash:/ ioslave.

arnav dhamija arnav.dhamija at gmail.com
Sun Sep 25 07:45:54 BST 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128666/
-----------------------------------------------------------

(Updated Sept. 25, 2016, 6:45 a.m.)


Review request for Dolphin, David Faure and Emmanuel Pescosta.


Changes
-------

Procrastinated for too long on this one, but it seems to work fine with stash:/ and it is certainly the better method over the previous patch.


Repository: dolphin


Description
-------

I am writing a new ioslave for Dolphin to make it possible to virtually stage directories without affecting the source. This requires the use of a targetUrl, but creating the mime data using the targetUrl is messing up my c/p operations through the Dolphin GUI as it does not respect the hierarchy of the stash:/ ioslave. Hence, I need createMimeData to use the item's url only for this ioslave. The special handling isn't very neat, but at least this way, it won't break any other existing ioslaves which need the targetUrl.


Diffs (updated)
-----

  src/kitemviews/kfileitemmodel.cpp 1f94972 

Diff: https://git.reviewboard.kde.org/r/128666/diff/


Testing
-------


Thanks,

arnav dhamija

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160925/18ba80cf/attachment.htm>


More information about the kfm-devel mailing list