Review Request 128666: Change KFileItemModel's createMimeData handling so it supports the upcoming stash:/ ioslave.

[Emmanuel Pescosta]

> On Sept. 13, 2016, 11:24 a.m., Boudhayan Gupta wrote:
> > Since no one has reviewed this patch and it's holding up the release of the stash ioslave, and since it doesn't look terrible to me by any standards, I'm giving this a Shipit.
> 
> Boudhayan Gupta wrote:
>     Oh my bad, the previews reviews didn't load properly. But in any case, just ship this. We can knock Dolphin into proper shape later.

> But in any case, just ship this. We can knock Dolphin into proper shape later.

No please don't do this. Fix it once and for all ;)
David already wrote how this problem should be fixed.


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128666/#review99141
-----------------------------------------------------------


On Aug. 13, 2016, 10:12 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128666/
> -----------------------------------------------------------
> 
> (Updated Aug. 13, 2016, 10:12 a.m.)
> 
> 
> Review request for Dolphin, David Faure and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> I am writing a new ioslave for Dolphin to make it possible to virtually stage directories without affecting the source. This requires the use of a targetUrl, but creating the mime data using the targetUrl is messing up my c/p operations through the Dolphin GUI as it does not respect the hierarchy of the stash:/ ioslave. Hence, I need createMimeData to use the item's url only for this ioslave. The special handling isn't very neat, but at least this way, it won't break any other existing ioslaves which need the targetUrl.
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodel.cpp 1f94972 
> 
> Diff: https://git.reviewboard.kde.org/r/128666/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160913/c6a9b521/attachment.htm>