Review Request 128853: Drop unneeded RTL workaround

[Safa Alfulaij]

> On سبتمبر 20, 2016, 10:45 ص, Emmanuel Pescosta wrote:
> > Thanks for the patch!
> > 
> > Why do you think that this is unneeded?
> > Isn't it the correct behavior in RTL mode when using the default shortcuts?
> > How do other applications with tabs behave in RTL mode?
> 
> Kai Uwe Broulik wrote:
>     QTabWidget layouts tabs from right to left in rtl mode, so "activate next tab" (ie. increasing the current index) will activate the tab *left* of it which is the correct behavior in this case.
>     
>     Patch makes sense imho.
> 
> Kai Uwe Broulik wrote:
>     Wait a secnd, I just noticed that while Dolphin tab widget aligns tabs on the right side, the order of tabs is still the same, so the first tab is the left-most one. It should be the other way round. Safa, can you check whether there's something else wrong / hardcoded in there?
> 
> Emmanuel Pescosta wrote:
>     Thanks for the info!
>     
>     Dolphin uses the QTabWidget for the tab handling (addTab, setCurrentIndex, ...). 
>     So if QTabWidget has support for RTL it should work in Dolphin as well ;)
>     But I can't find anything about the RTL behavior of QTabWidget/QTabBar in the Qt documentation.

Gif screenshot: http://i.imgur.com/sqeW24m.gif
I used Ctrl+Tab first (tabs are focused from left to right), then Ctrl+Shift+Tab (tabs are focused from right to left).
This is the current behaviour, which is wrong.

The first tab I opened is "safa", and the last one is "dolphinRTLTabs". The positioning of tabs are right.


- Safa


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/128853/#review99293
-----------------------------------------------------------


On سبتمبر 7, 2016, 1:03 م, Safa Alfulaij wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/128853/
> -----------------------------------------------------------
> 
> (Updated سبتمبر 7, 2016, 1:03 م)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The tab navigation shortcut workaround for RTL layouts is not needed anymore.
> RIght now, pressing Ctrl+Tab is making the **previous** tab (in RTL layout) the activated one, and vice versa.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp 34008b5 
> 
> Diff: https://git.reviewboard.kde.org/r/128853/diff/
> 
> 
> Testing
> -------
> 
> Just by logic
> 
> 
> Thanks,
> 
> Safa Alfulaij
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161012/85ca22c1/attachment.htm>