Review Request 129141: [search] Reload search view when file is deleted or copied
Anthony Fieroni
bvbfan at abv.bg
Mon Oct 10 15:51:35 BST 2016
> On Oct. 10, 2016, 4:45 p.m., Emmanuel Pescosta wrote:
> > > tell me how you expect to be implement this feature correctly
> >
> > Fix the `baloosearch` and `filenamesearch` ioslaves ;)
> > Those slaves have to listen whether files from the current query are deleted and forward this information to the application.
> >
> > For newly inserted items the slave has to permanently watch if new items are created which match with the current query -> resource intensive!
I "minimize" the fun
KCoreDirListerCache connects to KDirWatch (dirty, created, deleted) and org::kde::KDirNotify (FilesAdded, FilesChanged, FilesDeleted)
On first look, a bird view, KCoreDirListerCache looks correct, should i search bug in KDirWatch or KDirNotify, or to debug KCoreDirListerCache?
- Anthony
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129141/#review99911
-----------------------------------------------------------
On Oct. 10, 2016, 4:33 p.m., Anthony Fieroni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129141/
> -----------------------------------------------------------
>
> (Updated Oct. 10, 2016, 4:33 p.m.)
>
>
> Review request for Dolphin and Emmanuel Pescosta.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> Emmanuel, when it's performed some kind of search, deleting or inserting file does not update searching results till F5 is triggered. For me this behavior is annoying. This patch will *not* be pushed as is, tell me how you expect to be implement this feature correctly. I just *hack* emitted signal for delete / copyjob to retrigger search.
>
>
> Diffs
> -----
>
> src/dolphinviewcontainer.cpp 4e625c7
>
> Diff: https://git.reviewboard.kde.org/r/129141/diff/
>
>
> Testing
> -------
>
> Still not tested.
>
>
> Thanks,
>
> Anthony Fieroni
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161010/de37e025/attachment.htm>
More information about the kfm-devel
mailing list