Review Request 129044: Adding a dedicated Stash action button in Dolphin for the upcoming stash:/ ioslave

[Emmanuel Pescosta]

> On Sept. 29, 2016, 9:58 a.m., Boudhayan Gupta wrote:
> > At first glance, I don't see any code that disables or better yet removes the Stash button if the ioslave is absent. This must be there.
> 
> arnav dhamija wrote:
>     Yes, I will do this as soon as I get the time. This can be implemented by pinging the stash daemon on D-Bus and seeing if it is present.

Better use https://api.kde.org/frameworks/kio/html/classKProtocolInfo.html#a912ceb882acb0e57944ffa04aa2ee690


- Emmanuel


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129044/#review99653
-----------------------------------------------------------


On Sept. 27, 2016, 11:19 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129044/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 11:19 a.m.)
> 
> 
> Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The [stash:/ ioslave](https://github.com/KDE/kio-stash) provides an easy and convenient way for saving the URLs of complicated selections of files. To make this feature more useful, there have been suggestions to have a dedicated shortcut and GUI button for accessing the ioslave in a Split window. This patch adds a QAction in the DolphinMainWindow class for this purpose. The shortcut is subject to change and is currently set as Ctrl+**S**tash. By default, the action is visible in the View menu and the Toolbar of Dolphin.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.h 7003e94 
>   src/dolphinmainwindow.cpp 4d97fc1 
>   src/dolphintabpage.h 9d18088 
>   src/dolphintabpage.cpp c674e1e 
>   src/dolphinui.rc f197af4 
> 
> Diff: https://git.reviewboard.kde.org/r/129044/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of the button in the toolbar
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/27/2cb91ab8-5693-4953-b067-1ded856dd622__Screenshot_20160927_144649.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161003/24879d54/attachment.htm>