Review Request 129044: Adding a dedicated Stash action button in Dolphin for the upcoming stash:/ ioslave

[arnav dhamija]

> On Sept. 29, 2016, 6:26 a.m., Emmanuel Pescosta wrote:
> > About the stash action, in what circumstances the action should be enabled/disabled?
> > 
> > I guess it should only be enabled if:
> > 1. Split view isn't enabled (clicking on the stash action will open the stash folder in a split view)
> > 2. Split view is enabled and one view container shows the stash folder (clicking on the stash action will close the stash folder)
> > 
> > In all other cases it should be disabled, right?

The action will always be enabled? I don't see why it should be disabled in other cases - I was thinking of using it as a toggle button akin exactly to how the Split button already works. Basically, it toggles Split + go the Stash:/ URL.


- arnav


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129044/#review99649
-----------------------------------------------------------


On Sept. 27, 2016, 9:19 a.m., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129044/
> -----------------------------------------------------------
> 
> (Updated Sept. 27, 2016, 9:19 a.m.)
> 
> 
> Review request for Dolphin, Boudhayan Gupta, David Faure, and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The [stash:/ ioslave](https://github.com/KDE/kio-stash) provides an easy and convenient way for saving the URLs of complicated selections of files. To make this feature more useful, there have been suggestions to have a dedicated shortcut and GUI button for accessing the ioslave in a Split window. This patch adds a QAction in the DolphinMainWindow class for this purpose. The shortcut is subject to change and is currently set as Ctrl+**S**tash. By default, the action is visible in the View menu and the Toolbar of Dolphin.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.h 7003e94 
>   src/dolphinmainwindow.cpp 4d97fc1 
>   src/dolphintabpage.h 9d18088 
>   src/dolphintabpage.cpp c674e1e 
>   src/dolphinui.rc f197af4 
> 
> Diff: https://git.reviewboard.kde.org/r/129044/diff/
> 
> 
> Testing
> -------
> 
> 
> File Attachments
> ----------------
> 
> Screenshot of the button in the toolbar
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/09/27/2cb91ab8-5693-4953-b067-1ded856dd622__Screenshot_20160927_144649.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161003/c24e88f0/attachment.htm>