Review Request 129334: One line bug in KItemListWidget.cpp

Don Nguyen don78colorado at gmail.com
Mon Nov 21 16:42:31 GMT 2016


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129334/
-----------------------------------------------------------

(Updated Nov. 21, 2016, 4:42 p.m.)


Status
------

This change has been marked as submitted.


Review request for Dolphin.


Changes
-------

Submitted with commit 88805f7fad91b8d082f962462d1f8030a9c070c1 by Christoph Feck on behalf of Don Nguyen to branch master.


Repository: dolphin


Description
-------

previousWidth was set incorrectly.  since this variable isn't currently being used, it doesn't affect anything, but if someone tries to use it in the future, it would be incorrect.


Diffs
-----

  src/kitemviews/kitemlistwidget.cpp 9c31155 

Diff: https://git.reviewboard.kde.org/r/129334/diff/


Testing
-------

I tested it with the debugger to verify that the function that accepts this value (colunnWidthChanged) now gets the correct value (even tho it doesn't use it).


Thanks,

Don Nguyen

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161121/dd2c169a/attachment.htm>


More information about the kfm-devel mailing list