Review Request 129334: One line bug in KItemListWidget.cpp
Don Nguyen
don78colorado at gmail.com
Sun Nov 20 21:25:22 GMT 2016
> On Nov. 4, 2016, 11:59 p.m., Christoph Feck wrote:
> > Ship It!
Can you please commit this change for me? I do not have developer access. Thanks!
- Don
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129334/#review100582
-----------------------------------------------------------
On Nov. 4, 2016, 8:29 p.m., Don Nguyen wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129334/
> -----------------------------------------------------------
>
> (Updated Nov. 4, 2016, 8:29 p.m.)
>
>
> Review request for Dolphin.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> previousWidth was set incorrectly. since this variable isn't currently being used, it doesn't affect anything, but if someone tries to use it in the future, it would be incorrect.
>
>
> Diffs
> -----
>
> src/kitemviews/kitemlistwidget.cpp 9c31155
>
> Diff: https://git.reviewboard.kde.org/r/129334/diff/
>
>
> Testing
> -------
>
> I tested it with the debugger to verify that the function that accepts this value (colunnWidthChanged) now gets the correct value (even tho it doesn't use it).
>
>
> Thanks,
>
> Don Nguyen
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161120/d51fc0db/attachment.htm>
More information about the kfm-devel
mailing list