Review Request 129409: Fix scrolling in dock panels

[Elvis Angelaccio]

> On Nov. 17, 2016, 12:09 p.m., Emmanuel Pescosta wrote:
> > Thanks for debugging this issue!
> > 
> > I think that this approach is only a work-around instead of a real fix. 
> > For example if you change the icon size of the places panel the item height calculation will break.
> > 
> > I think that we should better use the size hint instead of the item size in KItemListContainer::updateScrollOffsetScrollBar().
> > In addition to m_logicalWidthHint the KItemListSizeHintResolver needs to determine the m_logicalHeightHint (min, median or max of m_maxLogicalHeightHint).
> 
> Emmanuel Pescosta wrote:
>     Ehm m_maxLogicalHeightHint should be m_logicalHeightHintCache
> 
> Elvis Angelaccio wrote:
>     Right, I forgot about changing the icon size...
>     I'll try your approach.

I used the max value, since all the values in the cache seems to be always equal.


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129409/#review100908
-----------------------------------------------------------


On Nov. 17, 2016, 2:45 p.m., Elvis Angelaccio wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129409/
> -----------------------------------------------------------
> 
> (Updated Nov. 17, 2016, 2:45 p.m.)
> 
> 
> Review request for Dolphin, Emmanuel Pescosta and Martin Tobias Holmedahl Sandsmark.
> 
> 
> Bugs: 365968
>     https://bugs.kde.org/show_bug.cgi?id=365968
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> The reason why scrolling is smooth in the DolphinView but not in the dock panels is: https://bugs.kde.org/show_bug.cgi?id=365968#c19
> 
> So we just need to set a default itemSize in the KStandardItemListView constructor.
> The itemHeight is computed like in DolphinItemListView::updateGridSize().
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kitemlistcontainer.cpp 6974ebb 
>   src/kitemviews/kitemlistview.h 9adf9f8 
>   src/kitemviews/kitemlistview.cpp df65399 
>   src/kitemviews/private/kitemlistsizehintresolver.h ff17f2d 
>   src/kitemviews/private/kitemlistsizehintresolver.cpp 1d80670 
> 
> Diff: https://git.reviewboard.kde.org/r/129409/diff/
> 
> 
> Testing
> -------
> 
> Scroll is now smoot both in Places and Folders dock panels. Tested with xf86-input-libinput and xf86-input-evded drivers, and libinput on Wayland.
> 
> 
> Thanks,
> 
> Elvis Angelaccio
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161117/d67c4fc1/attachment.htm>