Review Request 129409: Fix scrolling in dock panels

[Elvis Angelaccio]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129409/
-----------------------------------------------------------

(Updated Nov. 17, 2016, 2:45 p.m.)


Review request for Dolphin, Emmanuel Pescosta and Martin Tobias Holmedahl Sandsmark.


Changes
-------

Use height from KItemListSizeHintResolver's sizeHint(), instead of the itemSize(). This way the singleStep follows the icon size of the Places panel.


Bugs: 365968
    https://bugs.kde.org/show_bug.cgi?id=365968


Repository: dolphin


Description
-------

The reason why scrolling is smooth in the DolphinView but not in the dock panels is: https://bugs.kde.org/show_bug.cgi?id=365968#c19

So we just need to set a default itemSize in the KStandardItemListView constructor.
The itemHeight is computed like in DolphinItemListView::updateGridSize().


Diffs (updated)
-----

  src/kitemviews/kitemlistcontainer.cpp 6974ebb 
  src/kitemviews/kitemlistview.h 9adf9f8 
  src/kitemviews/kitemlistview.cpp df65399 
  src/kitemviews/private/kitemlistsizehintresolver.h ff17f2d 
  src/kitemviews/private/kitemlistsizehintresolver.cpp 1d80670 

Diff: https://git.reviewboard.kde.org/r/129409/diff/


Testing
-------

Scroll is now smoot both in Places and Folders dock panels. Tested with xf86-input-libinput and xf86-input-evded drivers, and libinput on Wayland.


Thanks,

Elvis Angelaccio

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161117/04fc1c0f/attachment.htm>