Review Request 127969: Use toggleViewAction directly rather than creating a new one

[Kai Uwe Broulik]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127969/#review95685
-----------------------------------------------------------



Ok, the reason probably was: when panels are locked I can no longer show/hide them using the shortcuts; the lock functionality is mostly for hiding the titles...

- Kai Uwe Broulik


On Mai 19, 2016, 6:23 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127969/
> -----------------------------------------------------------
> 
> (Updated Mai 19, 2016, 6:23 nachm.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> I don't see why we need a separate QAction.
> 
> This makes menus provided by Qt (eg. when right-clicking the menu bar or the header of an unlocked panel) consistent with Dolphin's own menus, ie. they also show icon and shortcut for the action.
> 
> 
> Diffs
> -----
> 
>   src/dolphinmainwindow.cpp 1fadaf7 
> 
> Diff: https://git.reviewboard.kde.org/r/127969/diff/
> 
> 
> Testing
> -------
> 
> Seems to work.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160521/bac00587/attachment.htm>