Review Request 127969: Use toggleViewAction directly rather than creating a new one
Kai Uwe Broulik
kde at privat.broulik.de
Thu May 19 19:23:32 BST 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127969/
-----------------------------------------------------------
(Updated Mai 19, 2016, 6:23 nachm.)
Review request for Dolphin.
Changes
-------
The action created by Qt is already checkable
Repository: dolphin
Description
-------
I don't see why we need a separate QAction.
This makes menus provided by Qt (eg. when right-clicking the menu bar or the header of an unlocked panel) consistent with Dolphin's own menus, ie. they also show icon and shortcut for the action.
Diffs (updated)
-----
src/dolphinmainwindow.cpp 1fadaf7
Diff: https://git.reviewboard.kde.org/r/127969/diff/
Testing
-------
Seems to work.
Thanks,
Kai Uwe Broulik
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160519/8861c253/attachment.htm>
More information about the kfm-devel
mailing list