Review Request 127955: [Settings Dialog] Show Trash settings only if authorized

[Kai Uwe Broulik]

> On Mai 18, 2016, 7:20 nachm., Emmanuel Pescosta wrote:
> > Thanks for the patch!
> > 
> > Is there a guideline somewhere which states what settings/actions should be locked down?
> > I'm asking because I think that we should also add such a check to the service settings page. (or should we simply add such checks to all pages?)

See [1], it works automagically in KCM stuff. The other pages aren't traditional KCMs, they don't have an associated service/desktop entry either and other places (like Folder View) have similar settings; not sure here.

If all else fails sysadmin could still mark certain configs in Dolphin as immutable or use KXmlGui which automatically enforces this to lock down specific actions [2] in order to prevent users from messing up their setup.

[1] https://userbase.kde.org/KDE_System_Administration/Kiosk/Introduction#KDE_Control_Module_Restrictions
[2] https://userbase.kde.org/KDE_System_Administration/Kiosk/Keys#File_Manager


- Kai Uwe


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127955/#review95592
-----------------------------------------------------------


On Mai 18, 2016, 6:09 nachm., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127955/
> -----------------------------------------------------------
> 
> (Updated Mai 18, 2016, 6:09 nachm.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> If this KCM is disabled through KIOSK restriction opening it would result in an error message. Hide the entry altogether in this case.
> 
> 
> Diffs
> -----
> 
>   src/settings/dolphinsettingsdialog.cpp 9eb57f1 
> 
> Diff: https://git.reviewboard.kde.org/r/127955/diff/
> 
> 
> Testing
> -------
> 
> Added
> 
> [KDE Control Module Restrictions]
> kcmtrash.desktop=false
> 
> Got no entry anymore. Without I still get it as before.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160518/09bbb1d0/attachment.htm>