Review Request 127955: [Settings Dialog] Show Trash settings only if authorized

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127955/#review95592
-----------------------------------------------------------



Thanks for the patch!

Is there a guideline somewhere which states what settings/actions should be locked down?
I'm asking because I think that we should also add such a check to the service settings page. (or should we simply add such checks to all pages?)


src/settings/dolphinsettingsdialog.cpp (lines 91 - 95)
<https://git.reviewboard.kde.org/r/127955/#comment64763>

    Can you please put this into a function and return the page instance? I would prefer it over the nullptr workaround :)



src/settings/dolphinsettingsdialog.cpp (lines 109 - 111)
<https://git.reviewboard.kde.org/r/127955/#comment64764>

    then simply do 
    if (KAuthorized::authorizeControlModule(...)) {
       m_pages.append(create...());
    }
    here ;)


- Emmanuel Pescosta


On May 18, 2016, 8:09 p.m., Kai Uwe Broulik wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127955/
> -----------------------------------------------------------
> 
> (Updated May 18, 2016, 8:09 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> If this KCM is disabled through KIOSK restriction opening it would result in an error message. Hide the entry altogether in this case.
> 
> 
> Diffs
> -----
> 
>   src/settings/dolphinsettingsdialog.cpp 9eb57f1 
> 
> Diff: https://git.reviewboard.kde.org/r/127955/diff/
> 
> 
> Testing
> -------
> 
> Added
> 
> [KDE Control Module Restrictions]
> kcmtrash.desktop=false
> 
> Got no entry anymore. Without I still get it as before.
> 
> 
> Thanks,
> 
> Kai Uwe Broulik
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160518/bd22d2f2/attachment.htm>