Review Request 127930: Fix crash when closing split view with ownCloud plugin loaded

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127930/#review95527
-----------------------------------------------------------



Thanks for the patch!

Can you please add ogoffart? Because he is the primary author of overlay icons.

- Emmanuel Pescosta


On May 16, 2016, 10:32 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127930/
> -----------------------------------------------------------
> 
> (Updated May 16, 2016, 10:32 p.m.)
> 
> 
> Review request for Dolphin, Emmanuel Pescosta and Michael Pyne.
> 
> 
> Bugs: 357479
>     https://bugs.kde.org/show_bug.cgi?id=357479
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> KPluginLoader::instantiatePlugins() wraps QPluginLoader::instance(),
> which doesn't return a new object for each call, so if we set the 
> KFileItemModelRolesUpdater instance as parent to the plugin the shared
> instance will be deleted leading to crashes when other instances of
> KFileItemModelRolesUpdater tries to use their plugin objects.
> 
> To fix this, set the QApplication as a parent.
> 
> BUG: 357479
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodelrolesupdater.cpp e5353dc 
> 
> Diff: https://git.reviewboard.kde.org/r/127930/diff/
> 
> 
> Testing
> -------
> 
> Yes.
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160517/00d00847/attachment.htm>