Review Request 127930: Fix crash when closing split view with ownCloud plugin loaded
Martin Tobias Holmedahl Sandsmark
martin.sandsmark at kde.org
Mon May 16 21:32:27 BST 2016
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127930/
-----------------------------------------------------------
(Updated May 16, 2016, 8:32 p.m.)
Review request for Dolphin, Emmanuel Pescosta and Michael Pyne.
Changes
-------
adding mpyne, which is the maintainer of KCoreAddons.
Bugs: 357479
https://bugs.kde.org/show_bug.cgi?id=357479
Repository: dolphin
Description (updated)
-------
KPluginLoader::instantiatePlugins() wraps QPluginLoader::instance(),
which doesn't return a new object for each call, so if we set the
KFileItemModelRolesUpdater instance as parent to the plugin the shared
instance will be deleted leading to crashes when other instances of
KFileItemModelRolesUpdater tries to use their plugin objects.
To fix this, set the QApplication as a parent.
BUG: 357479
Diffs
-----
src/kitemviews/kfileitemmodelrolesupdater.cpp e5353dc
Diff: https://git.reviewboard.kde.org/r/127930/diff/
Testing
-------
Yes.
Thanks,
Martin Tobias Holmedahl Sandsmark
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160516/8f96b324/attachment.htm>
More information about the kfm-devel
mailing list