Review Request 127902: [git plugin] Local changes and revert action

[Anthony Fieroni]

> On Май 12, 2016, 11:51 след обяд, Emmanuel Pescosta wrote:
> > git/fileviewgitplugin.cpp, line 408
> > <https://git.reviewboard.kde.org/r/127902/diff/1/?file=464678#file464678line408>
> >
> >     git difftool?
> >     
> >     We can't be sure that all our users have Kompare installed on their system, so better use the specified diff viewer from git.

git difftool --dir-diff shows all diffs dislikes context dir.


- Anthony


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127902/#review95434
-----------------------------------------------------------


On Май 12, 2016, 10:45 след обяд, Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127902/
> -----------------------------------------------------------
> 
> (Updated Май 12, 2016, 10:45 след обяд)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Show Local Git Changes looks ugly, but QProcess::startDetached(bash, -c git diff . | kompare-, fullpath) and git --git-dir=fullpath.git are even more uglier.
> 
> 
> Diffs
> -----
> 
>   git/fileviewgitplugin.h 3148b12 
>   git/fileviewgitplugin.cpp 8abc618 
> 
> Diff: https://git.reviewboard.kde.org/r/127902/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160513/82e1f029/attachment.htm>