Review Request 127902: [git plugin] Local changes and revert action

[Emmanuel Pescosta]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127902/#review95434
-----------------------------------------------------------




git/fileviewgitplugin.cpp (line 408)
<https://git.reviewboard.kde.org/r/127902/#comment64706>

    git difftool?
    
    We can't be sure that all our users have Kompare installed on their system, so better use the specified diff viewer from git.


- Emmanuel Pescosta


On May 12, 2016, 9:45 p.m., Anthony Fieroni wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127902/
> -----------------------------------------------------------
> 
> (Updated May 12, 2016, 9:45 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: dolphin-plugins
> 
> 
> Description
> -------
> 
> Show Local Git Changes looks ugly, but QProcess::startDetached(bash, -c git diff . | kompare-, fullpath) and git --git-dir=fullpath.git are even more uglier.
> 
> 
> Diffs
> -----
> 
>   git/fileviewgitplugin.h 3148b12 
>   git/fileviewgitplugin.cpp 8abc618 
> 
> Diff: https://git.reviewboard.kde.org/r/127902/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Anthony Fieroni
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160512/edc14f14/attachment.htm>