[KDE Usability] Review Request 127054: Add a Filter Toolbar Button for Dolphin

[Thomas Lübking]

> On März 12, 2016, 11:10 nachm., Thomas Lübking wrote:
> > dolphinmainwindow.cpp, line 1092
> > <https://git.reviewboard.kde.org/r/127054/diff/4/?file=449843#file449843line1092>
> >
> >     What exactly was the problem with
> >     
> >     QAction *showFilterBar ...;
> >     showFilterBar->setCheckable(true);
> >     ?
> 
> arnav dhamija wrote:
>     Right. So the problem with the QAction is that it doesn't have a "Pressed" state when the Filter button has been toggled. QPushButton probably would support do it but the rest of the Toggle buttons in the Dolphin Toolbar also use a KToggleAction (eg the Preview button) so I felt this approach makes more sense.
> 
> arnav dhamija wrote:
>     In the latest commit, I have usedcreated a checkable QAction to replace the KToggleAction which was causing Dolphin to crash when the Split view was opened. The reason for this is unclear, but QAction seems to be much more stable.

The crash cause will have been the toggled signal which is prone to cause recursions when bound to slots which, well, toggle the action ;-)


- Thomas


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127054/#review93458
-----------------------------------------------------------


On März 13, 2016, 11:48 nachm., arnav dhamija wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/127054/
> -----------------------------------------------------------
> 
> (Updated März 13, 2016, 11:48 nachm.)
> 
> 
> Review request for Dolphin, KDE Usability and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch was created to implement the feature suggested here: [https://todo.kde.org/?controller=task&action=show&task_id=966](https://todo.kde.org/?controller=task&action=show&task_id=966)
> 
> This patch adds a Filter Button to the toolbar of Dolphin. This button can be toggled to show/hide the Filter Bar.
> 
> In this patch, one might notice that there is now show_filter_bar and show_filter_bar_button in dolphinui.rc file. This was done because I found that using the same action for the menu entry and the toolbar entry would cause something to break (eg, shortcuts would stop working). 
> 
> A screenshot of the toolbar is also attached.
> 
> 
> Diffs
> -----
> 
>   dolphinmainwindow.h 7003e94 
>   dolphinmainwindow.cpp f7a7613 
> 
> Diff: https://git.reviewboard.kde.org/r/127054/diff/
> 
> 
> Testing
> -------
> 
> manual
> 
> 
> File Attachments
> ----------------
> 
> dolphintoolbar.png
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/02/12/d936e5d0-557c-45c5-9a2d-f849e5d284a6__dolphintoolbar.png
> 
> 
> Thanks,
> 
> arnav dhamija
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160314/a8b6de1f/attachment.htm>
-------------- next part --------------
_______________________________________________
kde-usability mailing list
kde-usability at kde.org
https://mail.kde.org/mailman/listinfo/kde-usability