Review Request 127054: Add a Filter Toolbar Button for Dolphin

[arnav dhamija]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/127054/
-----------------------------------------------------------

(Updated March 13, 2016, 9:53 a.m.)


Review request for Dolphin, KDE Usability and Emmanuel Pescosta.


Changes
-------

Replaced KToggleAction with a QAction for more stability


Repository: dolphin


Description
-------

This patch was created to implement the feature suggested here: [https://todo.kde.org/?controller=task&action=show&task_id=966](https://todo.kde.org/?controller=task&action=show&task_id=966)

This patch adds a Filter Button to the toolbar of Dolphin. This button can be toggled to show/hide the Filter Bar.

In this patch, one might notice that there is now show_filter_bar and show_filter_bar_button in dolphinui.rc file. This was done because I found that using the same action for the menu entry and the toolbar entry would cause something to break (eg, shortcuts would stop working). 

A screenshot of the toolbar is also attached.


Diffs (updated)
-----

  dolphinmainwindow.h 7003e94 
  dolphinmainwindow.cpp f7a7613 
  dolphinui.rc f197af4 

Diff: https://git.reviewboard.kde.org/r/127054/diff/


Testing
-------

manual


File Attachments
----------------

dolphintoolbar.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/02/12/d936e5d0-557c-45c5-9a2d-f849e5d284a6__dolphintoolbar.png


Thanks,

arnav dhamija

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160313/eb565866/attachment.htm>