Review Request 126799: Add optional confirmation dialog when hiding file by renaming inline

[Roman Gilg]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126799/
-----------------------------------------------------------

(Updated Jan. 21, 2016, 2:56 a.m.)


Review request for Dolphin and Emmanuel Pescosta.


Changes
-------

Removed checkbox in Dolphin settings, adapted to the design of the 'create hidden folder' dialog, won't trigger when hidden files are shown or on Windows in general.


Repository: dolphin


Description
-------

This patch is based on feature request https://bugs.kde.org/show_bug.cgi?id=356770 and implements a confirmation dialog when the user hides a file by renaming inline. This is meant to help new Unix users by not accidently hiding files.

It is possible to deactivate the confirmation dialog for future operations, which is saved in the Dolphin config.

Not yet considered in this basic implementation: Hiding files is generally dangerous for new users. So maybe there should allways be an (optional) warning, not only when editing filenames inline. Extending the backend by implementing the same confirmation dialog in KIO::moveAs() could be an idea for the future.


Diffs (updated)
-----

  src/settings/dolphin_generalsettings.kcfg 9ff14d1 
  src/settings/general/confirmationssettingspage.cpp 264024a 
  src/views/dolphinview.cpp 5023859 

Diff: https://git.reviewboard.kde.org/r/126799/diff/


Testing (updated)
-------

Arch, Plasma 5.5.3:
- Basic functionality
- Config saved, loaded


File Attachments (updated)
----------------

confirmhide.png
  https://git.reviewboard.kde.org/media/uploaded/files/2016/01/21/11a9241e-1828-47bf-a400-59ed316f93e6__confirmhide.png


Thanks,

Roman Gilg

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160121/8d033944/attachment.htm>