Review Request 126799: Add optional confirmation dialog when hiding file by renaming inline

[Roman Gilg]

> On Jan. 18, 2016, 9:48 p.m., Kai Uwe Broulik wrote:
> > Do we really need a setting for that? We don't have one for when you create a new file either.
> > 
> > Also the wording "On Unix based systems" is strange. Perhaps, if we want to keep it, only use that when it's actually run on a Unix system? The dialog I mentioned earlier doesn't mention that either.
> 
> Emmanuel Pescosta wrote:
>     > Do we really need a setting for that?
>     
>     Setting no, but dialog (with don't show again) yes IMHO. 
>     Hidding files/folders by writing a dot in front of the name is not obvious, and doing
>     it without knowing it can be really frustrating (where is my file - omg Dolphin removed
>     it!). So I think it's a good improvement for "newcomers" from a usability point of view.
>     
>     IMHO the new file dialog should also provide a confirmation box in such a case.
> 
> Kai Uwe Broulik wrote:
>     I was only really refering to the setting.
>     
>     Having a confirmation is good and only consistent because we ask for that when creating a file, so I would expect the same when renaming one. :)

Of course it's not really 'necessary'. On the other hand it's not such a big change and as in the request stated: When you get accidently in the inline rename mode for a PDF file "mydocument.pdf" and then press backspace and enter, you renamed the file to ".pdf", which would hide it. When I think about someone like my mum doing this by accident, she would freak out. ;)
Why is the wording strange? But I would also prefer running it only on Unix systems! I just had problems implementing it. Would the best way to use some declarative like 'Q_OS_UNIX'? Probably not...


- Roman


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126799/#review91283
-----------------------------------------------------------


On Jan. 18, 2016, 7:26 p.m., Roman Gilg wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/126799/
> -----------------------------------------------------------
> 
> (Updated Jan. 18, 2016, 7:26 p.m.)
> 
> 
> Review request for Dolphin and Emmanuel Pescosta.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> This patch is based on feature request https://bugs.kde.org/show_bug.cgi?id=356770 and implements a confirmation dialog when the user hides a file by renaming inline. This is meant to help new Unix users by not accidently hiding files.
> 
> It is possible to deactivate the confirmation dialog for future operations, which is saved in the Dolphin config.
> 
> Not yet considered in this basic implementation: Hiding files is generally dangerous for new users. So maybe there should allways be an (optional) warning, not only when editing filenames inline. Extending the backend by implementing the same confirmation dialog in KIO::moveAs() could be an idea for the future.
> 
> 
> Diffs
> -----
> 
>   src/settings/dolphin_generalsettings.kcfg 9ff14d1 
>   src/settings/general/confirmationssettingspage.h e702fe8 
>   src/settings/general/confirmationssettingspage.cpp 264024a 
>   src/views/dolphinview.cpp 5023859 
> 
> Diff: https://git.reviewboard.kde.org/r/126799/diff/
> 
> 
> Testing
> -------
> 
> Arch, Plasma 5.5.3
> 
> 
> Thanks,
> 
> Roman Gilg
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20160118/0aa89c45/attachment.htm>