Review Request 129619: Dolphin: directory loading progress

[Don Nguyen]

> On Dec. 6, 2016, 4:07 p.m., Emmanuel Pescosta wrote:
> > Ship It!
> 
> Christoph Feck wrote:
>     Is there already some code to avoid showing the progress bar for short loading times (< 1 sec), so that it does not flicker on every directory change?

Yes, a short period has to pass before a progress bar is shown.  I think it was .2 sec.  Then an "unknown" progress is shown until completion.  That is the current behavior.  Most of the directory loading happens so fast that you will not even get the percent signal from the directory lister.  I've tried 20,000 files on a local network as well as listing CD-ROMs and they still complete too quickly to emit a percent signal.  The only condition I came up with that will even trigger that signal was to use the fish protocol to list a remote directory with 20,000 files.


- Don


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129619/#review101314
-----------------------------------------------------------


On Dec. 5, 2016, 5:36 p.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129619/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 5:36 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Everything is already set up to show the directory loading progress in the status bar, but the signal KFileItemModel::directoryLoadingProgress is never emmited anywhere.  I connected it to KFileItemModelDirLister::percent.
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodel.cpp 05f85a6 
> 
> Diff: https://git.reviewboard.kde.org/r/129619/diff/
> 
> 
> Testing
> -------
> 
> This was difficult to test because I had a hard time finding a directory that didn't load almost immediately.  I was able to verify the fix by listing a remote directory of 20,000 files (see screenshot)
> 
> 
> File Attachments
> ----------------
> 
> directory loading progress in status bar
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/05/409a24a9-3272-4ab9-8e2d-18d309e33e64__loadProgress.png
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161206/0d1c7762/attachment.htm>