Review Request 129619: Dolphin: directory loading progress

[Christoph Feck]

> On Dec. 6, 2016, 5:07 p.m., Emmanuel Pescosta wrote:
> > Ship It!

Is there already some code to avoid showing the progress bar for short loading times (< 1 sec), so that it does not flicker on every directory change?


- Christoph


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129619/#review101314
-----------------------------------------------------------


On Dec. 5, 2016, 6:36 p.m., Don Nguyen wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129619/
> -----------------------------------------------------------
> 
> (Updated Dec. 5, 2016, 6:36 p.m.)
> 
> 
> Review request for Dolphin.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Everything is already set up to show the directory loading progress in the status bar, but the signal KFileItemModel::directoryLoadingProgress is never emmited anywhere.  I connected it to KFileItemModelDirLister::percent.
> 
> 
> Diffs
> -----
> 
>   src/kitemviews/kfileitemmodel.cpp 05f85a6 
> 
> Diff: https://git.reviewboard.kde.org/r/129619/diff/
> 
> 
> Testing
> -------
> 
> This was difficult to test because I had a hard time finding a directory that didn't load almost immediately.  I was able to verify the fix by listing a remote directory of 20,000 files (see screenshot)
> 
> 
> File Attachments
> ----------------
> 
> directory loading progress in status bar
>   https://git.reviewboard.kde.org/media/uploaded/files/2016/12/05/409a24a9-3272-4ab9-8e2d-18d309e33e64__loadProgress.png
> 
> 
> Thanks,
> 
> Don Nguyen
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161206/dc3e3b49/attachment.htm>