Review Request 129604: clazy warning fix for gci
Emmanuel Pescosta
emmanuelpescosta099 at gmail.com
Sat Dec 3 14:59:34 GMT 2016
> On Dec. 3, 2016, 3:54 p.m., Emmanuel Pescosta wrote:
> > CMakeLists.txt, line 11
> > <https://git.reviewboard.kde.org/r/129604/diff/2/?file=486947#file486947line11>
> >
> > Why the version bump?
>
> Elvis Angelaccio wrote:
> `Q_ENUM` is new in Qt 5.5, see https://woboq.com/blog/q_enum.html
Ah ok sorry then, missed the Q_ENUMS -> Q_ENUM
- Emmanuel
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129604/#review101239
-----------------------------------------------------------
On Dec. 3, 2016, 2:21 p.m., Spencer Brown wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129604/
> -----------------------------------------------------------
>
> (Updated Dec. 3, 2016, 2:21 p.m.)
>
>
> Review request for Dolphin and Elvis Angelaccio.
>
>
> Repository: dolphin
>
>
> Description
> -------
>
> Fixes 5 warnings reported in clazy - for googlecodein
>
>
> Diffs
> -----
>
> CMakeLists.txt 2d5c1c0
> src/kitemviews/kitemlistcontroller.h b8a93ed
> src/tests/kfileitemmodeltest.cpp 6c45e11
> src/tests/kitemsettest.cpp 0d14e20
>
> Diff: https://git.reviewboard.kde.org/r/129604/diff/
>
>
> Testing
> -------
>
> Confirmed that clazy does not report the warnings again from a clean build, - or any new ones.
>
>
> Thanks,
>
> Spencer Brown
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161203/1d69b8bb/attachment.htm>
More information about the kfm-devel
mailing list