Review Request 129604: clazy warning fix for gci

[Elvis Angelaccio]

> On Dec. 3, 2016, 2:54 p.m., Emmanuel Pescosta wrote:
> > CMakeLists.txt, line 11
> > <https://git.reviewboard.kde.org/r/129604/diff/2/?file=486947#file486947line11>
> >
> >     Why the version bump?

`Q_ENUM` is new in Qt 5.5, see https://woboq.com/blog/q_enum.html


- Elvis


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/129604/#review101239
-----------------------------------------------------------


On Dec. 3, 2016, 1:21 p.m., Spencer Brown wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/129604/
> -----------------------------------------------------------
> 
> (Updated Dec. 3, 2016, 1:21 p.m.)
> 
> 
> Review request for Dolphin and Elvis Angelaccio.
> 
> 
> Repository: dolphin
> 
> 
> Description
> -------
> 
> Fixes 5 warnings reported in clazy - for googlecodein
> 
> 
> Diffs
> -----
> 
>   CMakeLists.txt 2d5c1c0 
>   src/kitemviews/kitemlistcontroller.h b8a93ed 
>   src/tests/kfileitemmodeltest.cpp 6c45e11 
>   src/tests/kitemsettest.cpp 0d14e20 
> 
> Diff: https://git.reviewboard.kde.org/r/129604/diff/
> 
> 
> Testing
> -------
> 
> Confirmed that clazy does not report the warnings again from a clean build, - or any new ones.
> 
> 
> Thanks,
> 
> Spencer Brown
> 
>

-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://mail.kde.org/mailman/private/kfm-devel/attachments/20161203/0148e280/attachment.htm>